Don't allow admins to edit roster membership for other rosters #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirschn
commented
Sep 15, 2023
app/controllers/users_controller.rb
Outdated
| @@ -8,7 +8,7 @@ class UsersController < ApplicationController | |||
| WHITELISTED_ATTRIBUTES = [:first_name, :last_name, :spire, :email, | |||
| :phone, :active, :reminders_enabled, | |||
| :change_notifications_enabled, | |||
| { rosters: [], membership: [:admin] }].freeze | |||
| { roster_ids: [], membership: [:admin] }].freeze | |||
There was a problem hiding this comment.
I did this because it was annoying me and I kept getting confused about whether I had rosters or ids. Turns out, most of that confusion stemmed from parse_roster_ids, but I think this change is warranted either way.
werebus
requested changes
Sep 15, 2023
|
Also, Travis failures seem legit. |
The specs are being weird, I'll see what I can do but might end up translating to request specs. |
dirschn
commented
Sep 19, 2023
| @@ -7,6 +7,6 @@ | |||
| sequence(:spire) { |n| format('%[email protected]', n) } | |||
| sequence(:email) { |n| "user#{n}@umass.edu" } | |||
| sequence(:phone) { |n| format('+1413545%04d', n) } | |||
| rosters { [create(:roster)] } | |||
| roster_ids { [create(:roster).id] } | |||
There was a problem hiding this comment.
using roster_ids now, not rosters
werebus
requested changes
Sep 19, 2023
Co-authored-by: Matt Moretti <[email protected]>
werebus
approved these changes
Sep 19, 2023
|
Man, my bad. That should have been a |
I suppose that's what I get for blindly trusting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #293
closes #292
I was going to clean up the create and edit actions both, but doing so would require some significant refactoring. I am still open to cleaning up both, but I wanted to make sure other people agreed it was necessary/ perhaps it could be a follow up so we can close this issue sooner.