Merge pull request #2027 from unboxed/fix-default-search-filter

Don't exclude pre-review applications for reviewers
unboxed · Nov 12, 2024 · 4a8f07f · 4a8f07f
2 parents a53d9e5 + 01a47b7
commit 4a8f07f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 20 deletions.
diff --git a/app/services/planning_application_search.rb b/app/services/planning_application_search.rb
@@ -5,7 +5,6 @@ class PlanningApplicationSearch
   include ActiveModel::Attributes
 
   STATUSES = %w[not_started invalidated in_assessment awaiting_determination to_be_reviewed].freeze
-  REVIEWER_STATUSES = %w[awaiting_determination to_be_reviewed].freeze
 
   APPLICATION_TYPES = ApplicationType::NAME_ORDER
 
@@ -46,11 +45,7 @@ def call
   end
 
   def statuses
-    if reviewer? && exclude_others?
-      REVIEWER_STATUSES
-    else
-      STATUSES
-    end
+    STATUSES
   end
 
   def application_types

diff --git a/spec/system/filter_spec.rb b/spec/system/filter_spec.rb
@@ -306,7 +306,7 @@
           expect(page).to have_content("Your live applications")
           expect(page).to have_content(other_awaiting_determination_planning_application.reference)
           expect(page).to have_content(other_to_be_reviewed_planning_application.reference)
-          expect(page).not_to have_content(in_assessment_planning_application.reference)
+          expect(page).to have_content(in_assessment_planning_application.reference)
           expect(page).not_to have_content(closed_planning_application.reference)
           expect(page).not_to have_content(other_closed_planning_application.reference)
 

diff --git a/spec/system/planning_applications/index_spec.rb b/spec/system/planning_applications/index_spec.rb
@@ -675,19 +675,6 @@
       end
     end
 
-    it "Only Planning Applications that are awaiting_determination are present in this tab" do
-      find("span", text: "Filters").click
-      uncheck "To be reviewed"
-      click_button "Apply filters"
-
-      within(selected_govuk_tab) do
-        expect(page).to have_link(reviewer_planning_application_started.reference)
-        expect(page).not_to have_link(planning_application_1.reference)
-        expect(page).not_to have_link(planning_application_2.reference)
-        expect(page).not_to have_link(planning_application_completed.reference)
-      end
-    end
-
     it "Only Planning Applications that are determined are present in this tab" do
       click_link "Closed"