Fix issues with running lein ring server
#2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Compatibility issue: lein-ring and latest leiningen ``` clojure.lang.Compiler$CompilerException: Syntax error macroexpanding clojure.core/fn at (clojure/core/unify.clj:83:18). ``` `lein-ring` seems to be uncompatible with Leiningen 2.9.0 and above. Similar issues: * https://github.com/Azure/draft/issues/932 * https://translate.google.com/translate?hl=en&sl=zh-CN&u=https://xbuba.com/questions/54810552&prev=search 2) Incorrect lein-ring handler lein-ring had a wrong reference, but even if it was correct it should to be a handler not a fn. Since evaluation of app at boot doesn't seem to be harmful, I let myself to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I come across your repo by accident and while checking it out I found two minor issues related to lein-ring. I noticed that you probably run the app from main and the usage of lein-ring might be obsolate here. Despite that if in any case you wanted to keep lein-ring, this PR might help you. Otherwise please decline it.
Fix issues with running
lein ring serverCompatibility issue: lein-ring and latest leiningen
lein-ringseems to be uncompatible with Leiningen 2.9.0 and above.Similar issues:
Incorrect lein-ring handler
lein-ring had a wrong reference, but even if it was correct it should to be a handler not a fn.
Since evaluation of app at boot doesn't seem to be harmful, I let myself to change it.