Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use hypersolver #288

Merged
merged 5 commits into from
Sep 1, 2022
Merged

use hypersolver #288

merged 5 commits into from
Sep 1, 2022

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Aug 13, 2022

fixes #287

@ngam ngam marked this pull request as draft August 13, 2022 16:40
@ngam ngam marked this pull request as ready for review September 1, 2022 02:56
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 1, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.37%.

Quality metrics Before After Change
Complexity 2.27 ⭐ 3.04 ⭐ 0.77 👎
Method Length 56.33 ⭐ 42.79 ⭐ -13.54 👍
Working memory 7.89 🙂 8.69 🙂 0.80 👎
Quality 72.82% 🙂 72.45% 🙂 -0.37% 👎
Other metrics Before After Change
Lines 212 162 -50
Changed files Quality Before Quality After Quality Change
particula/rates.py 85.60% ⭐ 84.73% ⭐ -0.87% 👎
particula/util/radius_cutoff.py 46.73% 😞 47.12% 😞 0.39% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
particula/util/radius_cutoff.py cut_rad 7 ⭐ 160 😞 15 😞 47.12% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ngam ngam merged commit 7004116 into uncscode:main Sep 1, 2022
@ngam ngam deleted the 287-hypersolver branch September 1, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hypersolver
1 participant