Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gorkowski/issue352 (Sourcery refactored) #355

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Nov 12, 2023

Pull Request #354 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the Gorkowski/issue352 branch, then run:

git fetch origin sourcery/Gorkowski/issue352
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from ngam as a code owner November 12, 2023 16:40
@sourcery-ai sourcery-ai bot requested a review from Gorkowski November 12, 2023 16:40
particula/util/convert.py Show resolved Hide resolved
particula/util/convert.py Show resolved Hide resolved
particula/util/convert.py Show resolved Hide resolved
particula/util/convert.py Show resolved Hide resolved
particula/util/convert.py Show resolved Hide resolved
particula/util/convert.py Show resolved Hide resolved
particula/util/convert.py Show resolved Hide resolved
particula/util/stats.py Outdated Show resolved Hide resolved
particula/util/stats.py Show resolved Hide resolved
@Gorkowski Gorkowski merged commit 226227e into Gorkowski/issue352 Nov 12, 2023
@Gorkowski Gorkowski deleted the sourcery/Gorkowski/issue352 branch November 12, 2023 16:56
Gorkowski added a commit that referenced this pull request Nov 12, 2023
* pulled in data analysis files and updated test to 3.9
Fixes #352

* tests worked locally
Fixes #352

* Gorkowski/issue352 (Sourcery refactored) (#355)

* 'Refactored by Sourcery'

* small comments added back

---------

Co-authored-by: Sourcery AI <>
Co-authored-by: Kyle Gorkowski <[email protected]>

* updated doc string and init

* try that for an empty list check

* fixed line cont.

* ok, lets see where we are at

* 'Refactored by Sourcery' (#356)

Co-authored-by: Sourcery AI <>

* couple lint updates

* updated dependencies
Fixes #352

* maybe like that for objects type hints

* removed some files from pytype

* hints fixed on loaders

* lets just skip loader_interface then, added exampl

* push v13

* updated stale times

* removed loader for pytype

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant