Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic logger #452

Merged
merged 10 commits into from
May 6, 2024
Merged

Add basic logger #452

merged 10 commits into from
May 6, 2024

Conversation

Gorkowski
Copy link
Collaborator

Fixes #451

Copy link

github-actions bot commented May 3, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-452/
on branch gh-pages at 2024-05-05 00:36 UTC

@Gorkowski Gorkowski marked this pull request as ready for review May 4, 2024 00:12
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gorkowski - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

particula/__init__.py Show resolved Hide resolved
particula/logger_setup.py Outdated Show resolved Hide resolved
particula/logger_setup.py Outdated Show resolved Hide resolved
particula/tests/logging_setup_test.py Outdated Show resolved Hide resolved
particula/tests/logging_setup_test.py Outdated Show resolved Hide resolved
Gorkowski and others added 5 commits May 3, 2024 18:14
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@Gorkowski Gorkowski requested review from ngmahfouz and ngam May 4, 2024 00:32
@Gorkowski Gorkowski enabled auto-merge May 4, 2024 01:58
@Gorkowski Gorkowski added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit e7bcda0 May 6, 2024
8 checks passed
@Gorkowski Gorkowski deleted the Gorkowski/issue451 branch May 6, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic logger
2 participants