Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Condensation PR gas properties #453

Merged
merged 9 commits into from
May 24, 2024
Merged

Pre-Condensation PR gas properties #453

merged 9 commits into from
May 24, 2024

Conversation

Gorkowski
Copy link
Collaborator

@Gorkowski Gorkowski commented May 11, 2024

Summary of Changes in this PR:

  • Next Gas Properties:

    • Moved gas properties functions into a dedicated gas.properties directory to improve locational reference and accessibility.
    • This restructuring aims to reduce code bloat in the utils module of version 1 by compartmentalizing functions related to gas properties.
    • Due to name space overlap, all test are prefixed prop_XXX_test.py. We can remove in v1.
  • Updated Logger Configuration:

    • Modified the logging setup to exclusively capture logs from particula.
    • This change addresses the issue of extraneous debug logs from matplotlib cluttering the log files, ensuring cleaner and more relevant log outputs.
  • Arrays in Reduced Quantity Calculations:

    • Introduced two new functions in the reduced_quantity module to handle calculations for both individual and array-based inputs:
      • One function is tailored for array to array calculations.
      • The second function is designed for self operations of arrays, enhancing computational efficiency and utility for batch processing.

Copy link

github-actions bot commented May 11, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-453/
on branch gh-pages at 2024-05-11 19:37 UTC

@Gorkowski Gorkowski added this to the v0.1.0 milestone May 11, 2024
@Gorkowski Gorkowski added the next prototype for v1 label May 11, 2024
@Gorkowski Gorkowski self-assigned this May 11, 2024
@Gorkowski Gorkowski marked this pull request as ready for review May 11, 2024 19:13
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

particula/util/reduced_quantity.py Outdated Show resolved Hide resolved
Gorkowski and others added 3 commits May 11, 2024 13:14
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@Gorkowski Gorkowski requested review from ngmahfouz and ngam May 11, 2024 19:19
@Gorkowski Gorkowski enabled auto-merge May 11, 2024 19:34
@Gorkowski Gorkowski added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 9feaacd May 24, 2024
8 checks passed
@Gorkowski Gorkowski deleted the gas-prop branch May 24, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next prototype for v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants