Pre-Condensation 3- activity #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gorkowski
changed the title
|
Gorkowski
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #457
Summary:
This PR initiates the transition to focusing on particle-related properties by integrating activity coefficients essential for partial pressure calculations in vapor-liquid equilibrium/condensation processes within aerosols.
New Files:
activity_strategies.py: Introduces ideal mixing rules for both molar and mass-based calculations and kappa parameterizations for non-ideal water uptake.activity_builders.py: Implements validation and unit conversions in the creation of activity strategies.activity_factories.py: Facilitates the quick selection and building of activity strategies using the newly added builders for enhanced validation.Changes:
convert.py: Updated to include the conversion from mass concentration to mole fractions, supporting the new activity strategies.