Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py312 #495

Merged
merged 1 commit into from
Oct 6, 2024
Merged

py312 #495

merged 1 commit into from
Oct 6, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Oct 6, 2024

Summary by Sourcery

Update the CI configuration to include Python 3.12 in the testing matrix, ensuring compatibility with the latest Python version.

CI:

  • Add Python 3.12 to the testing matrix in the GitHub Actions workflow.

Summary by Sourcery

Update the CI configuration to include Python 3.12 in the testing matrix.

CI:

  • Add Python 3.12 to the testing matrix in the GitHub Actions workflow to ensure compatibility with the latest Python version.

Copy link
Contributor

sourcery-ai bot commented Oct 6, 2024

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflow configuration to include Python 3.12 in the testing matrix. The change ensures that the project is tested against the latest Python version, expanding the compatibility range.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add Python 3.12 to the CI testing matrix
  • Update the 'python-version' array in the matrix strategy
  • Add '3.12' to the list of Python versions to be tested
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mahf708 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mahf708
Copy link
Contributor Author

mahf708 commented Oct 6, 2024

@sourcery-ai summary

Copy link
Contributor

sourcery-ai bot commented Oct 6, 2024

I'm sorry, I don't understand the command @sourcery-ai summary.

Please use @sourcery-ai review to request a review.

@mahf708
Copy link
Contributor Author

mahf708 commented Oct 6, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mahf708 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mahf708 mahf708 added this pull request to the merge queue Oct 6, 2024
Merged via the queue into uncscode:main with commit d048146 Oct 6, 2024
9 checks passed
@mahf708 mahf708 deleted the relax-pins branch October 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants