Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid compilation failure in ARM64 #3

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Avoid compilation failure in ARM64 #3

merged 4 commits into from
Mar 26, 2020

Conversation

drodriguezhdez
Copy link
Contributor

No description provided.

@drodriguezhdez drodriguezhdez self-assigned this Mar 25, 2020
tonyredondo
tonyredondo approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@tonyredondo tonyredondo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be treated as a workaround for those architectures.

We should try to port the function to arm and arm64 in the foreseeable future.

@tonyredondo
Copy link
Contributor

tonyredondo commented Mar 25, 2020 •
edited
Loading

I was thinking, its better to change the function return values, to []byte, error. That way we avoid the panic, and handle the error... Patch method already return err, so we can return the error there...

lets talk about it before merging this.

tonyredondo
tonyredondo reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@tonyredondo tonyredondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait before merge

tonyredondo
tonyredondo requested changes Mar 26, 2020
View reviewed changes
patcher_arm.go Outdated Show resolved Hide resolved
patcher_arm64.go Outdated Show resolved Hide resolved
tonyredondo
tonyredondo approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@tonyredondo tonyredondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, please test it before merge that we don't break anything :)

@drodriguezhdez drodriguezhdez merged commit 1a86426 into master Mar 26, 2020
@drodriguezhdez drodriguezhdez deleted the support_arm branch March 26, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

@drodriguezhdez drodriguezhdez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drodriguezhdez @tonyredondo