This repository has been archived by the owner on Aug 17, 2020. It is now read-only.
Send metadata until at least one payload is successfully delivered #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyredondo
force-pushed
the
once-metadata
branch
from
cc527a7
to
ba8a700
Compare
agent/recorder.go
Outdated
| "spans": spans, | ||
| "events": events, | ||
| tags.AgentID: r.agentId, | ||
| } | ||
| // We send the metadata only if not spans are sent successfully | ||
| if atomic.LoadInt64(&r.stats.sendSpansOk) == 0 { |
There was a problem hiding this comment.
So if sendSpansOK > 0, the metadata will not be sent, right?
Is this already supported in the backend?
There was a problem hiding this comment.
Not released yet in the backend, I made this PR because @AdrianLC need it to test the feature in the backend. We will merge it when the backend gets ready.
tonyredondo
force-pushed
the
once-metadata
branch
from
ba8a700
to
52a7805
Compare
tonyredondo
force-pushed
the
once-metadata
branch
5 times, most recently
from
4aecfbd
to
b4cafed
Compare
tonyredondo
force-pushed
the
once-metadata
branch
from
9ae8b79
to
6303c3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRenables the recorder to send the metadata in the payload until at least one span is delivered successfully.