This repository has been archived by the owner on Aug 17, 2020. It is now read-only.
Global panic handler as an agent option #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
drodriguezhdez
approved these changes
Mar 26, 2020
|
Great! It compiles |
|
What you think about using this branch to use the new version of |
|
Compiles with autoinstrumentation |
|
@tonyredondo please let me know if LGTY |
|
Can you test with a breakpoint if the global panic handler its working when using autoinstrument? To make sure of that. I can test it but not right now |
|
It's working because if you tested with the previous go-mpatch version and with autoinstrumentation, it didn't compile. |
|
Ohh perfect, then LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207
This
PRmoves the global panic handler from thescopeagent.Runmethod to an option for the agent, this options it's added in the auto instrumentation by default.This should fix the okteto problem while compiling for arm64.