This repository has been archived by the owner on Aug 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking with Benchmarks, it seems there are no benchmarks tags. It is benchmark tests supported? Should I add something to the code to enable benchmarks?
Command:
|
You're right, Benchmark instrumentation is missing.... I don't know if it's better in a next PR, because this one is quite big already. What do you think? @drodriguezhdez |
Sure. Let's go for other PR for Benchmarks. |
drodriguezhdez
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for go check framework, instrument the suites and the log funcs. Also support ITR and runner retries.
https://shared.scope.dev/dashboard/8cee2622-8772-4338-8d72-63653e0e0239/2205d752-62a8-45e8-b12d-5b40f3cc4c71/default/explore/inspect/7a74b0737151106c38e38094de7e9c07ed007f0b/