Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

Adds Go check support #240

Merged
merged 28 commits into from
May 28, 2020
Merged

Adds Go check support #240

merged 28 commits into from
May 28, 2020

Conversation

tonyredondo
Copy link
Contributor

@tonyredondo tonyredondo commented May 21, 2020

This PR adds support for go check framework, instrument the suites and the log funcs. Also support ITR and runner retries.

https://shared.scope.dev/dashboard/8cee2622-8772-4338-8d72-63653e0e0239/2205d752-62a8-45e8-b12d-5b40f3cc4c71/default/explore/inspect/7a74b0737151106c38e38094de7e9c07ed007f0b/

image

image

image

@tonyredondo tonyredondo self-assigned this May 21, 2020
@tonyredondo tonyredondo marked this pull request as ready for review May 21, 2020 19:12
@tonyredondo tonyredondo requested a review from fermayo May 21, 2020 19:14
@drodriguezhdez
Copy link
Contributor

Checking with Benchmarks, it seems there are no benchmarks tags. It is benchmark tests supported? Should I add something to the code to enable benchmarks?

import (
	. "gopkg.in/check.v1"
	"testing"

	_ "go.undefinedlabs.com/scopeagent/autoinstrument"
)

func Test(t *testing.T) { TestingT(t) } // Step 2

type TestSuite struct{} // Step 3

var _ = Suite(&TestSuite{}) // Step 4

func (s *TestSuite) BenchmarkLogic(c *C) {
	for i := 0; i < c.N; i++ {
		c.Assert("asd", Equals,"asd")
	}
}

Command:

$ go test -gocheck.b

image

@tonyredondo
Copy link
Contributor Author

You're right, Benchmark instrumentation is missing.... I don't know if it's better in a next PR, because this one is quite big already. What do you think? @drodriguezhdez

@drodriguezhdez
Copy link
Contributor

Sure. Let's go for other PR for Benchmarks.

Copy link
Contributor

@drodriguezhdez drodriguezhdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

image

image

@tonyredondo tonyredondo merged commit 0146678 into master May 28, 2020
@tonyredondo tonyredondo deleted the go-check branch May 28, 2020 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants