Skip to content

Commit

Permalink
Fix CI/CD fail by install ImageMagick on runners
Browse files Browse the repository at this point in the history
This commit addresses an issue where CI/CD jobs fail due to the removal of
`imagemagick` from GitHub's preinstalled software list for Ubuntu
runners. As a result, commands relying on `imagemagick` were not found.

To resolve this, the commit installs `imagemagick` across all platforms
(Linux, macOS, and Windows). This safeguards against future changes to
the preinstalled software list on GitHub runners.
  • Loading branch information
undergroundwires committed Oct 11, 2024
1 parent 74378f7 commit 94069b3
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions .github/workflows/checks.scripts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,24 @@ on:

jobs:
icons-build:
runs-on: ${{ matrix.os }}-latest
runs-on: ${{ matrix.os.name }}-latest
strategy:
matrix:
os: [ macos, ubuntu, windows ]
os:
- name: macos
install-imagemagick-command: brew install imagemagick
- name: ubuntu
install-imagemagick-command: sudo apt install -y imagemagick
- name: windows
install-imagemagick-command: choco install -y imagemagick
fail-fast: false # Still interested to see results from other combinations
steps:
-
name: Checkout
uses: actions/checkout@v4
-
name: Install ImageMagick on macOS
if: matrix.os == 'macos'
run: brew install imagemagick
name: Install ImageMagick
run: ${{ matrix.os.install-imagemagick-command }}
-
name: Setup node
uses: ./.github/actions/setup-node
Expand Down

0 comments on commit 94069b3

Please sign in to comment.