Avoid existential types in implicits #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure `HListShape` has the correct `ShapeLevel`. Fixes milessabin/shapeless#619
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 1 1
Lines 16 16
=======================================
Hits 15 15
Misses 1 1
Continue to review full report at Codecov.
|
d6y
reviewed
Jan 23, 2018
There was a problem hiding this comment.
Thank you @joroKr21 - LGTM!
@milessabin do you want cast an eye over this as it relates to shapeless issue 619?
|
@milessabin @davegurnell I'll merge this and release tomorrow (or soon after) unless there are objections or anyone wants to do a second review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure
HListShapehas the correctShapeLevel.Closes milessabin/shapeless#619