IDs for Floating Action Button items

[birchamp]

No description provided.

[birchamp]

Work with Daniel on finding missing IDs.

[danielklapp]

Restoring minimized cards

• Parent container (div class="jss28") to have good meaningful ID that makes it unique.
• Child containers (div class= "jss29") to have CSS class names of what components they are if possible.

Total of eight child containers I'm testing to restore:

• Literal Translation
• Original Source
• Simplified Translation
• translationNotes
• translationAcademy
• translationWords List
• translationWords Article
• translationQuestions

[PhotoNomad0]

Notes:
also each card unique id for minimize and save.
also merge buttons and alignment buttons.

[jincypjose]

These are the id's to click on
show_minimized_cards
close_minimized_cards
restore_button_resource_card_tq for Translation questions
restore_title_resource_card_tq for Translation questions
restore_title_scripture_card_Literal_Translation for Literal Translation
restore_button_scripture_card_Literal_Translation for Literal Translation
restore_title_scripture_card_Original_Source for Original Source
restore_button_scripture_card_Original_Source for Original Source
restore_title_scripture_card_Simplified_Translation for Simplified Translation
restore_button_scripture_card_Simplified_Translation for Simplified Translation
restore_title_resource_card_ta for Translation academy
restore_button_resource_card_ta for Translation academy
restore_title_resource_card_twl for Translation Word List
restore_button_resource_card_twl for Translation Word List
restore_title_resource_card_twa for Translation Words Article
restore_button_resource_card_twa for Translation Words Article

[jincypjose]

@danielklapp @elsylambert the fixes are in https://release-v2-0-0--gateway-edit.netlify.app
version- v1.2.0 build b660927

[danielklapp]

@jincypjose IDs for buttons is looking Great!
I've noticed it would be helpful to add IDs to the alignment buttons that specific to Literal Translation card, Original Source card, and Simplified Translation card.

[PhotoNomad0]

@jincypjose IDs for buttons is looking Great! I've noticed it would be helpful to add IDs to the alignment buttons that specific to Literal Translation card, Original Source card, and Simplified Translation card.

We need to talk about this, since the scripture cards are not fixed, they can be swapped or changed point to about any scripture repo.

[PhotoNomad0]

@jincypjose @danielklapp - since each card could be changed to point to different scriptures, perhaps it is best to make the ids for the alignment buttons consistant with the other buttons. For example instead of id="alignment_icon_TARGET_LITERAL", do id="alignment_icon_TARGET_LITERAL" id="alignment_icon_scripture_card_0".

There are several ids in ScriptureCard.tsx that need to be changed:

• valid_icon_${resourceId}
• invalid_alignment_icon_${resourceId}
• alignment_icon_${resourceId}

where "${resourceId}" should be replaced with "scripture_card_${cardNum}"

[PhotoNomad0]

Also in the FAB's we have:

id="restore_title_scripture_card_Original_Source"
id="restore_button_scripture_card_Original_Source"

to fix the id's make changes in the WorkspaceContainer.js of GWE. change the id values for the scripture cards in const cards = [ to be scripture_card_${cardNum}

[PhotoNomad0]

To fix the title, in single-scripture-rcl ScriptureCard change

        onMinimize={onMinimize ? () => onMinimize(id) : null}

to be

        onMinimize={onMinimize ? () => onMinimize(id, scriptureLabel) : null}

And in resource-workspace-rcl useMinimizedCardsState,

• add a state variable to persist titles const [minimizedCardTitles, setMinimizedCardTitles] = useUserLocalStorage('minimizedCardITitles', {});
• need to add a title as second parameter to const minimizeCard = (id) => {
• and in the function add the title to minimizedCardTitles
• and need to change minimizedCards declaration to be a useMemo and return items that match contained in minimizedCardIds and replacing the titles if contained in minimizedCardTitles

[birchamp]

@jincypjose please hand this off to @Joel-C-Johnson and let him know what's left to be done

[jincypjose]

@Joel-C-Johnson i have did what need have to be done in ScriptureCard.tsx as bruce metioned above. Now the WorkspaceContainer.js need to be fixed with cardNum.

[danielklapp]

@Joel-C-Johnson can you give an update about the changes you’ve made and how we can test those changes?

[Joel-C-Johnson]

Hi @danielklapp, I will right the steps here and if you have doubts please ping me on Discord.
1. Login into gatewayedit - https://gateway-edit.netlify.app/
2. Open inspect and click on each card using the "pick element tool"

3. You can able to see unique id's for cards and icons
4. Minimize cards using the '-" icon in the cards
5. you can able see recent cards on the right side

6. click on it and you can see the list of cards with unique id and names

[danielklapp]

@Joel-C-Johnson thanks, just wanted to make sure my testing covered all work you guys did.

[elsylambert]

Looks good in v2.1.0 build 66dd56e QA. Seeing IDs in Restore card button icons.

[danielklapp]

Looks good to me. I see unique IDs for all the buttons listed. Tested with v2.1.0 build 66dd56e QA.