-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #355 / Fix when dcs user has no organizations #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kintsoogi
changed the title
WIP: Bugfix #355 / Fix when dcs user has no organizations
Bugfix #355 / Fix when dcs user has no organizations
Jan 9, 2023
PhotoNomad0
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code review
LGTM - testing - awesome job! |
PhotoNomad0
added a commit
that referenced
this pull request
Apr 3, 2023
* Updated .gitignore testing files/paths * Changed Jest coverage directory to jest-coverage * Changed Cyprees coverage directory to cypress-coverage, added multiple scripts to combined Cypress and Jest test coverage reports * Added step to github action to combine Cypress & Jest coverage reports * Added another step to github action to upload combined coverage report to Coveralls * README.md * Test * recovered * jest.config.js * Added badges to README.md * README.md * Migrated from coveralls to codecov for code coverage reporting * set ubuntu-latest on gh action, updated badges * t * gh action twaeks * Removed unnecesary codecov token * Updated badges version numbers * Fixes for running in Windows and README.md * updated instructions. * Created MinimizableWrapper.js * Created MinimizedCards.js * Created useMinimizedCardState.js custom hook * Updated secondary theme main color * Created MinimizedCards FAB component * Fixing minimized card bug * Created MinimizedCards component * Code clean-up on MinimizedCards.js * Added onMinimize method prop to ResourceCard.js * Code clean-up & added data persistence to minimized cards in useMinimizedCardState hook * removed src/components/MinimizableWrapper.js * Added more code comments to useMinimizedCardState * Added minimize/restore feature to resource cards * yarn.lock * Typo * Improved varuable name in useMinimizedCardState * Moved MinimizedCards component and useMinimizedCardState.js from gateway edit app to resource-workspace-rcl to allow for other apps to gain the minimize card feature * Removed unused framer-motion dependency * Updated respective dependencies * fix for unformatted paste * adding UI Design documentation to README.md * Further small edit in README.md * Bugfix larsg 337 usfm new version (#339) * WIP-updated to new version usfm-js #133 * bump version * #328 - bumped version for translation-helps-rcl (#345) * bumped version for translation-helps-rcl * include latest mui (v5) * included emotion (styled, react) * bumped version - boxes no longer displayed when not focused * fixed yarn.lock * bumped version for rcl component - translation-helps-rcl * Fix account settings behavior * Bugfix #355 / Fix when dcs user has no organizations (#356) * Removed circular progress and show disabled org/language select when user has no orgs * Added lock file changes * Bugfix #358... updated translation-helps to load GL Quotes (#359) * updated translation-helps-rcl dependency * updated translation-helps-rcl version * Updated verion to 1.1 (#366) * Feature #330/ampersand support (#371) * merged Lars' ampersand fixes * updating scripture resource rcl * quote and occurrences cleanup * rebuild * rebuild * add support for verse ranges in scripture pane highlighting * add support for verse ranges in scripture pane highlighting * update dependencies * update dependencies --------- Co-authored-by: Manny Colon <[email protected]> Co-authored-by: Bruce McLean <[email protected]> Co-authored-by: Cecil New <[email protected]> Co-authored-by: larsgson <[email protected]> Co-authored-by: Kintsoogi <[email protected]> Co-authored-by: Abel Pérez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed circular progress and show disabled org/language select when user has no orgs
Describe what your pull request addresses
Test Instructions