Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 399/Move merge from master into App #405

Merged
merged 11 commits into from
Apr 13, 2023

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Apr 13, 2023

Describe what your pull request addresses

  • [ ]

Test Instructions

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #405 (05b5cf6) into develop (ac64e0c) will increase coverage by 1.20%.
The diff coverage is 69.44%.

@@             Coverage Diff             @@
##           develop     #405      +/-   ##
===========================================
+ Coverage    46.22%   47.43%   +1.20%     
===========================================
  Files           39       41       +2     
  Lines         1127     1189      +62     
===========================================
+ Hits           521      564      +43     
- Misses         606      625      +19     
Impacted Files Coverage Δ
src/components/Layout.js 55.55% <ø> (ø)
src/components/WorkspaceContainer.js 61.59% <ø> (ø)
src/context/StoreContext.js 72.00% <57.14%> (-10.76%) ⬇️
src/components/ResourceCard.js 70.83% <85.71%> (+1.60%) ⬆️
src/components/Header.js 69.23% <87.50%> (+6.07%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PhotoNomad0 PhotoNomad0 changed the title Feature jincy 399 phase 2 Feature 399/Move merge from master into App Apr 13, 2023
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review April 13, 2023 18:39
@PhotoNomad0 PhotoNomad0 merged commit 84f7e6f into develop Apr 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature-jincy-399-phase2b branch April 13, 2023 19:52
Copy link
Contributor

@kintsoogi kintsoogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kintsoogi pushed a commit that referenced this pull request Sep 27, 2023
added merge status to the store context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants