Fixed false-conflict and added error handling for no changes made #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhotoNomad0
requested changes
Jun 23, 2023
package.json
Outdated
| @@ -54,7 +54,7 @@ | |||
| "single-scripture-rcl": "3.4.4", | |||
| "tailwindcss": "^2.0.4", | |||
| "tc-ui-toolkit": "5.3.3", | |||
| "translation-helps-rcl": "3.4.2", | |||
| "translation-helps-rcl": "3.4.3-beta", | |||
There was a problem hiding this comment.
Good work cleaning up the code and sorting through the hazards!
Just waiting for you to publish and update translation-helps-rcl
Codecov Report
@@ Coverage Diff @@
## develop #493 +/- ##
========================================
Coverage 50.83% 50.83%
========================================
Files 43 43
Lines 1314 1314
========================================
Hits 668 668
Misses 646 646
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kintsoogi
added a commit
that referenced
this pull request
Sep 27, 2023
kintsoogi
added a commit
that referenced
this pull request
Sep 29, 2023
* Fixed false-conflict and added error handling for no changes made * updated tHelps version * darn tootin yarn locks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what your pull request addresses
Test Instructions