Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved user choices for columns in TSV Fix -#1150 #1626

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Saved user choices for columns in TSV Fix -#1150 #1626

merged 2 commits into from
Oct 24, 2023

Conversation

Joel-C-Johnson
Copy link
Collaborator

Describe what your pull request addresses (Please include relevant issue numbers):

  • When the user adds or removes visible columns, changing TSV files or restarting the session, doesn't affect which columns are shown.

Test instructions for your pull request:

  • Login into the app
  • Select en_tn and book (eg: TIT)
  • Click on the View column icon (Note only the rowHeader is clicked. In all books the rowheader will be default)
  • click on the other columns checklist and change the book
  • the selected columns remain the same for other books even if it doesn't effect after logout

Joel-C-Johnson
Joel-C-Johnson commented Oct 24, 2023
View reviewed changes
Copy link
Collaborator Author

@Joel-C-Johnson Joel-C-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code changes

@Joel-C-Johnson Joel-C-Johnson merged commit 73d6093 into develop Oct 24, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Joel-C-Johnson