Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/fix for \qs* end tag #19

Merged
merged 4 commits into from
Aug 20, 2024
Merged

bugfix/fix for \qs* end tag #19

merged 4 commits into from
Aug 20, 2024

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Aug 16, 2024

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Is the repo documentation accurate/appropriate?
    • Check Stylguidist if applicable
    • Check readme for correct information about the feature being worked on
  • Check that there are not inadvertent commits
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for word-aligner ready!

Name Link
🔨 Latest commit 4ce2e04
🔍 Latest deploy log https://app.netlify.com/sites/word-aligner/deploys/66c52aa55709de00086301dd
😎 Deploy Preview https://deploy-preview-19--word-aligner.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PhotoNomad0 PhotoNomad0 changed the title Bugfix / fix qs bugfix/fix for \qs* end tag Aug 16, 2024
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review August 20, 2024 23:46
@PhotoNomad0 PhotoNomad0 merged commit 5e732ee into master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant