Skip to content

Commit

Permalink
Merge branch 'dev' into fix/coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
TeddyRoncin committed Sep 7, 2024
2 parents d85d9ec + b2cf44f commit a4c607a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/controllers/admin/tournaments/updateTournament.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ export default [
name: Joi.string().optional(),
maxPlayers: Joi.number().optional(),
cashprize: Joi.number().optional(),
cashprizeDetails: Joi.string().optional(),
cashprizeDetails: Joi.string().allow('').optional(),
displayCashprize: Joi.boolean().optional(),
format: Joi.string().optional(),
infos: Joi.string().optional(),
format: Joi.string().allow('').optional(),
infos: Joi.string().allow('').optional(),
casters: Joi.array().items(Joi.string()).optional(),
displayCasters: Joi.boolean().optional(),
display: Joi.boolean().optional(),
Expand Down
8 changes: 8 additions & 0 deletions tests/admin/tournaments/updateTournament.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,4 +192,12 @@ describe('PATCH /admin/tournaments/{tournamentId}', () => {
const tournamentDatabase = await tournamentOperations.fetchTournament(tournament.id);
expect(tournamentDatabase.maxPlayers).to.equal(validBody.maxPlayers);
});

it('should allow for empty strings in fields `format` and `infos`', async () => {
await request(app)
.patch(`/admin/tournaments/${tournament.id}`)
.send({ format: '', infos: '' })
.set('Authorization', `Bearer ${adminToken}`)
.expect(200);
});
});
9 changes: 6 additions & 3 deletions tests/fake.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ import { createFakeTeam, createFakeUser } from './utils';
await database.cart.deleteMany();
await database.log.deleteMany();
await database.team.deleteMany();
await database.log.deleteMany();
await database.cart.deleteMany();
await database.orgaRole.deleteMany();
await database.orga.deleteMany();
await database.user.deleteMany();

Expand Down Expand Up @@ -66,19 +69,19 @@ import { createFakeTeam, createFakeUser } from './utils';
username: 'ua_admin',
password: defaultPassword,
email: '[email protected]',
permissions: [Permission.admin],
permissions: [Permission.admin, Permission.orga],
});
await createFakeUser({
username: 'ua_entry',
password: defaultPassword,
email: '[email protected]',
permissions: [Permission.entry],
permissions: [Permission.entry, Permission.orga],
});
await createFakeUser({
username: 'ua_anim',
password: defaultPassword,
email: '[email protected]',
permissions: [Permission.anim],
permissions: [Permission.anim, Permission.orga],
});

// Set login and shop to allowed
Expand Down

0 comments on commit a4c607a

Please sign in to comment.