Feat/position in items #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevNono
approved these changes
Oct 17, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #160 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 110 110
Lines 2338 2336 -2
Branches 332 332
==========================================
- Hits 2254 2252 -2
Misses 46 46
Partials 38 38
☔ View full report in Codecov by Sentry. |
DevNono
pushed a commit
that referenced
this pull request
Sep 10, 2024
* test: a tournament was modified in this test * feat: items now have a position * fix: forgot some commented code --------- Co-authored-by: Teddy Roncin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add position for items
Changes
Now when returning the list of items, they will be ordered