Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc): fix coach limit blocking new players in team #76

Merged
merged 2 commits into from
Oct 5, 2021
Merged

fix(misc): fix coach limit blocking new players in team #76

merged 2 commits into from
Oct 5, 2021

Conversation

AlbanSdl
Copy link
Member

@AlbanSdl AlbanSdl commented Oct 5, 2021

Correction de bugs:

  • identifiants smtp dans une uri
  • les tableaux vides ne sont plus générés dans les mails
  • plus jamais de redirect_uri invalide pendant les tests d'oauth en localhost

@AlbanSdl AlbanSdl added the urgent Something that is urgent to merge label Oct 5, 2021
@AlbanSdl AlbanSdl added this to the billetterie-front milestone Oct 5, 2021
@AlbanSdl AlbanSdl self-assigned this Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #76 (dc00ee8) into dev (5716dd7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #76   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files          78       78           
  Lines        1541     1541           
  Branches      212      210    -2     
=======================================
  Hits         1469     1469           
  Misses         48       48           
  Partials       24       24
Impacted Files Coverage Δ
src/operations/team.ts 96.07% <100.00%> (+0.07%) ⬆️
src/services/email/components.ts 100.00% <100.00%> (ø)
src/utils/env.ts 88.13% <100.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5716dd7...dc00ee8. Read the comment docs.

@AlbanSdl
fix(misc): fix coach limit blocking new players in team
942e75e 
* smtp credentials are now in a an uri format
* empty tables will now longer be rendered in emails
* fixed localhost invalid redirect_uri for discord oauth
ThomasLachaux
ThomasLachaux reviewed Oct 5, 2021
View reviewed changes
.env.example Show resolved Hide resolved
src/utils/env.ts Show resolved Hide resolved
src/utils/env.ts Show resolved Hide resolved
@ThomasLachaux ThomasLachaux added the changes requested The PR is stalled and needs changes label Oct 5, 2021
@ThomasLachaux ThomasLachaux added ready to merge The assignee can merge the PR and removed changes requested The PR is stalled and needs changes labels Oct 5, 2021
@AlbanSdl AlbanSdl merged commit 72df595 into dev Oct 5, 2021
@AlbanSdl AlbanSdl deleted the fix/misc branch October 5, 2021 12:33
DevNono pushed a commit that referenced this pull request Sep 10, 2024
@AlbanSdl
fix(misc): fix coach limit blocking new players in team (#76)
4ab3f53 
* fix(misc): fix coach limit blocking new players in team

* smtp credentials are now in a an uri format
* empty tables will now longer be rendered in emails
* fixed localhost invalid redirect_uri for discord oauth

* docs: update discord.md and fake.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLachaux ThomasLachaux ThomasLachaux approved these changes

Assignees

@AlbanSdl AlbanSdl

Labels
ready to merge The assignee can merge the PR urgent Something that is urgent to merge
Projects
None yet
Milestone
billetterie-front
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbanSdl @ThomasLachaux