Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explicited-errors): translated empty login's error #80

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

CocoChart
Copy link
Contributor

  • L'erreur '"login" is not allowed to be empty' est maintenant en français
  • ajout de l'erreur dans les types
  • ajout du test correspondant

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #80 (4bfdcd1) into dev (4e2cd28) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #80      +/-   ##
==========================================
- Coverage   95.33%   95.27%   -0.07%     
==========================================
  Files          78       78              
  Lines        1544     1545       +1     
  Branches      211      212       +1     
==========================================
  Hits         1472     1472              
  Misses         48       48              
- Partials       24       25       +1     
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/utils/env.ts 86.66% <0.00%> (-1.47%) ⬇️
src/controllers/auth/login.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4dba1...4bfdcd1. Read the comment docs.

@CocoChart CocoChart merged commit d4f7ebe into dev Oct 6, 2021
@CocoChart CocoChart deleted the fix/expliciterrors branch October 6, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants