Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tickets): emails now don't send the tickets as attachments #82

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

CocoChart
Copy link
Contributor

  • Retrait de la pièce jointe et du message l'indiquant

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #82 (a7aa563) into dev (403d0c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #82   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          78       78           
  Lines        1545     1545           
  Branches      212      212           
=======================================
  Hits         1472     1472           
  Misses         48       48           
  Partials       25       25           
Impacted Files Coverage Δ
src/services/email/serializer.ts 100.00% <ø> (ø)
src/controllers/etupay/callback.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403d0c6...a7aa563. Read the comment docs.

@CocoChart CocoChart merged commit 68a4bc4 into dev Oct 6, 2021
@AlbanSdl AlbanSdl deleted the fix/tickets branch October 7, 2021 08:16
DevNono pushed a commit that referenced this pull request Sep 10, 2024
* fix(tickets): emails now don't send the tickets as attachments

* fix(tickets): fixed the failing test

* fix(tickets): added back attachments to sendEmail function

* fix(tickets): adapted the test to last changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants