Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17081 Fix PNF test data for ICU #3270

Merged
merged 6 commits into from
Sep 13, 2023
Merged

CLDR-17081 Fix PNF test data for ICU #3270

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68205b2
CLDR-17081 Fix PNF test data for ICU
macchiati Sep 12, 2023
49aea55
CLDR-17081 More complete test of qualifying PNF data
macchiati Sep 12, 2023
f5713d6
CLDR-17081 Make fixes to gd and gl
macchiati Sep 12, 2023
44481e9
CLDR-17081 Fix case hacks
macchiati Sep 12, 2023
5bc1158
CLDR-17081 Fix remaining gl issue
macchiati Sep 12, 2023
b9d1815
CLDR-17081 And run the testData generation
macchiati Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions common/main/gd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15148,27 +15148,21 @@ CLDR data files are interpreted according to the LDML specification (http://unic
</personName>
<personName order="sorting" length="long" usage="referring" formality="formal">
<namePattern>{surname-core}, {given} {given2} {surname-prefix}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
</personName>
<personName order="sorting" length="long" usage="referring" formality="informal">
<namePattern>{surname}, {given-informal} {given2}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
</personName>
<personName order="sorting" length="medium" usage="referring" formality="formal">
<namePattern>{surname-core}, {given} {given2-initial} {surname-prefix}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
</personName>
<personName order="sorting" length="medium" usage="referring" formality="informal">
<namePattern>{surname}, {given-informal} {given2}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
<namePattern>{surname}, {given-informal} {given2-informal-initial}</namePattern>
</personName>
<personName order="sorting" length="short" usage="referring" formality="formal">
<namePattern>{surname-core}, {given-initial} {given2-initial} {surname-prefix}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
</personName>
<personName order="sorting" length="short" usage="referring" formality="informal">
<namePattern>{surname}, {given-informal} {given2}</namePattern>
<namePattern alt="1">{surname-core}, {given-informal} {given2} {surname-prefix}</namePattern>
<namePattern>{surname}, {given-informal} {given2-informal-initial}</namePattern>
</personName>
<sampleName item="nativeG">
<nameField type="given">Calum</nameField>
Expand Down
11 changes: 5 additions & 6 deletions common/main/gl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9797,27 +9797,26 @@ Warnings: All cp values have U+FE0F characters removed. See /annotationsDerived/
<personName order="sorting" length="long" usage="referring" formality="formal">
<namePattern>{surname-core} {surname2}, {given} {given2} {surname-prefix}</namePattern>
<namePattern alt="1">{surname-core}, {given} {given2} {surname-prefix}</namePattern>
<namePattern alt="2">↑↑↑</namePattern>
</personName>
<personName order="sorting" length="long" usage="referring" formality="informal">
<namePattern>{surname-core} {surname2}, {given-informal} {surname-prefix}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
<namePattern alt="1">{surname-core}, {given-informal} {surname-prefix}</namePattern>
</personName>
<personName order="sorting" length="medium" usage="referring" formality="formal">
<namePattern>{surname-core} {surname2}, {given} {given2-initial} {surname-prefix}</namePattern>
<namePattern alt="1">{surname-core} {surname2}, {given} {given2} {surname-prefix}</namePattern>
<namePattern alt="1">{surname-core}, {given} {given2} {surname-prefix}</namePattern>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want this to be {given2} when the first entry has {given2-initial}?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this, will examine in 1/2 hour

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it (lined up all the others for comparison, too, so I wouldn't miss any others). Good catch.

</personName>
<personName order="sorting" length="medium" usage="referring" formality="informal">
<namePattern>{surname-core} {surname2}, {given-informal} {surname-prefix}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
<namePattern alt="1">{surname-core}, {given-informal} {surname-prefix}</namePattern>
</personName>
<personName order="sorting" length="short" usage="referring" formality="formal">
<namePattern>{surname-core} {surname2}, {given-initial} {given2-initial} {surname-prefix}</namePattern>
<namePattern alt="1">{surname-core} {surname2}, {given-initial} {given2-initial} {surname-prefix}</namePattern>
<namePattern alt="1">{surname-core}, {given-initial} {given2-initial} {surname-prefix}</namePattern>
</personName>
<personName order="sorting" length="short" usage="referring" formality="informal">
<namePattern>{surname-core} {surname2}, {given-informal} {surname-prefix}</namePattern>
<namePattern alt="1">↑↑↑</namePattern>
<namePattern alt="1">{surname-core}, {given-informal} {surname-prefix}</namePattern>
</personName>
<sampleName item="nativeG">
<nameField type="given">Uxía</nameField>
Expand Down
276 changes: 0 additions & 276 deletions common/testData/personNameTest/br.txt
View file
Open in desktop

This file was deleted.

Loading
Loading