Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17669 add Organization.airbnb #3747

Merged
merged 5 commits into from
May 23, 2024
Merged

CLDR-17669 add Organization.airbnb #3747

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c575b8f
CLDR-17669 add Organization.airbnb
srl295 May 23, 2024
68b5b21
CLDR-17669 add Organization.airbnb
srl295 May 23, 2024
6bdc26a
CLDR-17669 add Organization.airbnb
srl295 May 23, 2024
4379085
CLDR-17669 add Organization.airbnb
srl295 May 23, 2024
4be856d
CLDR-17669 add Organization.airbnb
srl295 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCLDRLocaleCoverage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,16 +393,24 @@ public void TestParentCoverage() {
if (parent == null || parent.equals(LocaleNames.ROOT)) {
break;
}
if (!defaultContentLocales.contains(parent) && !parent.equals("en_001")) { // en_001 is generated later from en_GB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in formatting make it hard to see what the real change was. How did the original of this file escape being formatted by spotless?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't escape, it was formatted 'correctly'

The main change is just adding a defaultContent check. The rest is just test output changes.

if (!defaultContentLocales.contains(parent)
&& !parent.equals("en_001")) { // en_001 is generated later from en_GB
Level parentLevel = localesToLevels.get(parent);
if (assertNotNull(
String.format("Locales.txt: Entry '%s ; %s ; ...' is missing parent '%s ; %s ; ...'", organization, originalLocale, organization,
parent),
parentLevel)) {
String.format(
"Locales.txt: Entry '%s ; %s ; ...' is missing parent '%s ; %s ; ...'",
organization, originalLocale, organization, parent),
parentLevel)) {
assertTrue(
String.format("Locales.txt: Entry '%s ; %s ; %s' should not be higher than parent '%s ; %s ; %s'",
organization, originalLocale, level, organization, parent, parentLevel),
parentLevel.compareTo(level) >= 0);
String.format(
"Locales.txt: Entry '%s ; %s ; %s' should not be higher than parent '%s ; %s ; %s'",
organization,
originalLocale,
level,
organization,
parent,
parentLevel),
parentLevel.compareTo(level) >= 0);
}
}
locale = parent;
Expand Down
Loading