CLDR-17842 Add semantic skeleton spec text #4031
Conversation
sffc
changed the title
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Please advise on how and where I should indicate that this is a technology preview. |
|
Look at the message format Part
…On Mon, Sep 9, 2024, 19:10 Shane F. Carr ***@***.***> wrote:
Please advise on how and where I should indicate that this is a technology
preview.
—
Reply to this email directly, view it on GitHub
<#4031 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMD6SRZH6NX7CZEUWVLZVZIKPAVCNFSM6AAAAABN5WGWNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGQ3TANRYGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
| | { Hour, Minute } | 4:03 pm | 16:03 | | ||
| | { Hour, Minute, Second } | 4:03:51 pm | 16:03:51 | | ||
|
|
||
| Note: Minute and Second are not valid time field sets on their own because they do not refer to a particular time of day. They must be interpreted in the context of an explicit hour. |
There was a problem hiding this comment.
Add a note somewhere that formatting durations, like 3 minutes 12 seconds (or 3:12) is not handled through the Skeleton mechanisms.
docs/ldml/tr35-dates.md
Outdated
|
|
||
| The _year style_ defines the level of precision to use when displaying the year. There are three choices: | ||
|
|
||
| 1. **Auto:** Display the year with full or partial precision, and display the era if needed to disambiguate the year, depending on locale, calendar, and length. Example: Jan. 1, '00 |
There was a problem hiding this comment.
Use ‘00 instead of '00; add another example esp for Auto. We need to make sure that people are not mislead into thinking that Auto is confined.
| 1. **Auto:** Display the year with full or partial precision, and display the era if needed to disambiguate the year, depending on locale, calendar, and length. Example: Jan. 1, '00 | |
| 1. **Auto:** Display the year with full or partial precision, and display the era if needed to disambiguate the year, depending on locale, calendar, and length. Example: Jan. 1, ‘00 or 1 January 2000 |
Now that I think about it, it might be clearer with a little table for each of the style options, instead of a numbered list.
There was a problem hiding this comment.
I used a lot of tables, but I didn't here because there was too much inline text, which doesn't render very well with tables.
EDIT: In this specific case, I added a table.
docs/ldml/tr35-dates.md
Outdated
|
|
||
| The [year style](#Semantic_Skeleton_Year_Style) should change the skeleton for all lengths as follows: | ||
|
|
||
| - Auto: No change from datetimeSkeleton |
There was a problem hiding this comment.
Add a note: the datetimeSkeleton may already be y; and may include G already, subject to locale preferences.
There was a problem hiding this comment.
Similar notes elsewhere, just for clarity.
|
I believe I addressed all the feedback. |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Squashed |
|
I'm not sure what the test failure is for:
|
|
I think someone mentioned that that is an ICU problem (that I think was fixed, and that we just need to upgrade to the latest ICU). @DraganBesevic @pedberg-icu |
|
@eggrobin PTAL |
|
The build problem looks completely unrelated to this PR. @srl295 any ideas? |
|
Shane, Steven says you need to remerge or rebase on top of latest main |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Sorry for the delay; I rebased on top of main |
CLDR-17842
ALLOW_MANY_COMMITS=true