Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18001 site: fix link in ToC to entire page, fix some titles #4126

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 10, 2024

CLDR-18001

  • suppress link to title in ToC, hide ToC if empty

  • suppress title h1 entirely, add centered title

  • shift ToC over to the left one

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Review Notes

  • check links in ToC on index and subpages
  • check the /development page as an example of a page that will not have a 'Content' sidebar in this change

image

image

- if the first H1 is the same as the title, change the href in the ToC to go to the entire page
- If there isn't a redundant H1 , synthesize an entry in the ToC
@srl295 srl295 requested a review from macchiati October 10, 2024 17:43
@srl295 srl295 self-assigned this Oct 10, 2024
Copy link

✨ deployed to https://cf52a071.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Oct 10, 2024
macchiati
macchiati previously approved these changes Oct 10, 2024
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

BTW

  • We definitely need a page explaining the title requirements. Not part of GFM and not documented that quotes are required. (What happens if they aren't there??)
  • I think we need to drop the first line of the contents; I'd added that to https://unicode-org.atlassian.net/browse/CLDR-18017. But that can be later.

- related to CLDR-18017
- suppress redundant h1 (#), but add centered title
- suppress title from ToC. Hide ToC if empty.
@srl295
Copy link
Member Author

srl295 commented Oct 10, 2024

Looks good.

BTW

  • We definitely need a page explaining the title requirements. Not part of GFM and not documented that quotes are required. (What happens if they aren't there??)

if not there the PR may reject or it may truncate. I updated the doc

Sorry, inflight merge conflict. - the same instant you were reviewing, I was reading and implementing CLDR-18017 which dropped your review.

Copy link

✨ deployed to https://34c47ec7.cldr.pages.dev

@srl295 srl295 merged commit 62f93db into main Oct 10, 2024
14 of 15 checks passed
@srl295 srl295 deleted the srl295/cldr-18001/site-suppress-redundant-h1 branch October 10, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants