Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect nightly in icu_capi_freertos, bump to 1.2.1 #3394

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

Manishearth
Copy link
Member

Alternative to #3382

This fixes the nightly breakage by introducing --cfg needs_alloc_error_handler and setting it via build script using the rustc_version crate.

I'm okay adding this dependency for now because FreeRTOS is a rare use case and it is likely that people who care about precise dep count will also be using a custom build system (where this build script won't run in the first place)

The polarity of this check is that recent nightly needs no cfg, since as I've mentioned in chat it is good practice when using Rust nightly to focus on recent nightly; and our happy path should be aligned with that.

@Manishearth Manishearth requested a review from a team as a code owner April 26, 2023 00:03
@Manishearth Manishearth requested a review from sffc April 26, 2023 00:03
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • ffi/freertos/build.rs is now changed in the branch
  • ffi/freertos/src/lib.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Manishearth Manishearth merged commit 7017c3e into unicode-org:main Apr 26, 2023
@Manishearth
Copy link
Member Author

Merging now so we have it for our nightly CI run in an hour. I'll do the publish in a while

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants