Detect nightly in icu_capi_freertos, bump to 1.2.1 #3394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3382
This fixes the nightly breakage by introducing
--cfg needs_alloc_error_handler
and setting it via build script using therustc_version
crate.I'm okay adding this dependency for now because FreeRTOS is a rare use case and it is likely that people who care about precise dep count will also be using a custom build system (where this build script won't run in the first place)
The polarity of this check is that recent nightly needs no
cfg
, since as I've mentioned in chat it is good practice when using Rust nightly to focus on recent nightly; and our happy path should be aligned with that.