Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress nightly lint forget_copy in yoke_impls.rs #3437

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

sffc
Copy link
Member

@sffc sffc commented May 15, 2023

Fixes #3436

@sffc sffc requested a review from Manishearth as a code owner May 15, 2023 22:26
@sffc
Copy link
Member Author

sffc commented May 15, 2023

Hmm?

error: lint name `forget_copy` is deprecated and may not have an effect in the future.
 --> utils/zerovec/src/yoke_impls.rs:6:10
  |
6 | #![allow(forget_copy)]
  |          ^^^^^^^^^^^ help: change it to: `clippy::forget_copy`
  |
  = note: `-D renamed-and-removed-lints` implied by `-D warnings`

@sffc sffc requested a review from robertbastian May 15, 2023 22:49
@sffc sffc changed the title Try to fix nightly error in yoke_impls.rs Fix nightly lint forget_copy in yoke_impls.rs May 15, 2023
@sffc sffc changed the title Fix nightly lint forget_copy in yoke_impls.rs Suppress nightly lint forget_copy in yoke_impls.rs May 15, 2023
@sffc
Copy link
Member Author

sffc commented May 15, 2023

Feel free to merge once CI is green.

@robertbastian robertbastian merged commit 8ba9224 into main May 16, 2023
@robertbastian robertbastian deleted the sffc-patch-4 branch May 16, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeroVec Yoke impl started failing "forget-copy" on Nightly
2 participants