Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASM build #608

Closed
wants to merge 2 commits into from
Closed

Fix WASM build #608

wants to merge 2 commits into from

Conversation

sffc
Copy link
Member

@sffc sffc commented Apr 3, 2021

Fixes #607

I downgraded the rand crate because the new version does not build on WASM. I filed rust-random/rand#1110 for fixing the issue upstream.

EDIT: I fixed the issue by passing the "js" feature to getrandom, as suggested in the above thread.

@sffc sffc requested a review from Manishearth April 3, 2021 17:53
@sffc sffc requested a review from a team as a code owner April 3, 2021 17:53
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/litemap/Cargo.toml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@coveralls
Copy link

coveralls commented Apr 3, 2021

Pull Request Test Coverage Report for Build af52a8ff9a66bf8bff6b44949e0e3f066c34791b-PR-608

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.2%) to 72.586%

Files with Coverage Reduction New Missed Lines %
components/provider_cldr/src/transform/likelysubtags.rs 5 84.91%
components/provider_cldr/src/transform/plurals.rs 6 71.3%
components/provider_cldr/src/transform/numbers/mod.rs 7 79.83%
components/provider_cldr/src/support.rs 16 11.76%
components/provider_cldr/src/transform/mod.rs 19 11.43%
components/provider_cldr/src/transform/dates.rs 43 72.8%
Totals Coverage Status
Change from base Build 2c75da6e082dbe16d9ce9a5c513d30d9f92991e1: 0.2%
Covered Lines: 6908
Relevant Lines: 9517

💛 - Coveralls

Manishearth
Manishearth previously approved these changes Apr 3, 2021
@sffc
Copy link
Member Author

sffc commented Apr 5, 2021

I'm going to close this as subsumed by #609.

@sffc sffc closed this Apr 5, 2021
@sffc sffc deleted the fix-wasm branch April 5, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM build is broken :(
3 participants