Github Workflow for building wheels #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WrathfulSpatula - Please check that the resulting artifacts are OK. |
WrathfulSpatula
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Thank you for your hard work on this! You explained that you ran into problems building the artifacts for Windows, and that's absolutely no issue: I maintain local hardware running every OS on every instruction set that we officially support. I wanted to take the work you did here and also incorporate it into the C++ Qrack repository itself, to build its similar artifacts automatically and save me some manual labor, every release.
We can merge this, and I'll adapt it for the C++ Qrack repository, but thanks again, and please reach out to me if you encounter any issue with claiming the bounty!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close issue #23 - this is a GitHub workflow for building and publishing the wheels, based on the bash script suggested in the issue.
Currently only builds wheels for MacOS and Linux.