Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOTS Compatibility | Shader does not appear to work with Hybrid Renderer V2 #96

Open
krooq opened this issue Dec 17, 2021 · 1 comment

Comments

@krooq
Copy link

krooq commented Dec 17, 2021

When I try to use this shader in DOTS with hybrid renderer V2 I get the following error.

A Hybrid Renderer V2 batch is using the shader "Universal Render Pipeline/Toon", but the shader is either not compatible with Hybrid Renderer V2, is missing the DOTS_INSTANCING_ON variant, or there is a problem with the DOTS_INSTANCING_ON variant.
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)

I also get a bunch of warnings about the shader not supporting skinning, e.g.

Shader [Universal Render Pipeline/Toon] on [Face] does not support skinning. This can result in incorrect rendering.
Please see documentation for Linear Blend Skinning Node and Compute Deformation Node in Shader Graph.

I have the following relevant defines declared
ENABLE_HYBRID_RENDERER_V2
ENABLE_COMPUTE_DEFORMATIONS

Using packages:
Unity 2020.3.25f
Universal RP 10.7.0
Hybrid Renderer 0.11.0-preview.44
Universal Toon Shader for URP 2.3.0

This is probably a URP/Hybrid Renderer bug, but I am not shader savvy enough to figure it out, hoping someone here can help.

@H3idi-X
Copy link
Contributor

H3idi-X commented Dec 25, 2021

We are not 100% sure. but, we would like to share our status of ECS support for UTS. As UTS has a lot of shader variants already, ECS still drastically changes and unlisted in package manager for now.
Maybe, it's hard for us to give high priority to support ECS for a while.

yuki4080 pushed a commit to yuki4080/com.unity.toonshader that referenced this issue Dec 22, 2022
* Removed unnecessary functions.

* Fixed: _autoRenderQueue is not initialized in UTS_GUIBase.cs

* Updated CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants