#3388 Bugfix for cpp template function return types #3416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3416 +/- ##
==========================================
- Coverage 83.22% 83.21% -0.02%
==========================================
Files 218 218
Lines 52449 52439 -10
==========================================
- Hits 43650 43635 -15
- Misses 8799 8804 +5
Continue to review full report at Codecov.
|
|
Could you add a test case? |
|
sure, I'll add a unit test when I get to it! |
|
The codecov coverage threshold check is failing and there also seems to be a flaky test here: https://github.com/universal-ctags/ctags/runs/7044140203; I also added a small fix for a comment that was introduced in #3398 (see aaf6ca2) |
|
@masatake any more comments on this PR? |
|
These can be squashed into one commit. We should not record your try-and-error commits to the ctags history if possible. About e7fbffe, I would like you to start the header of the commit log with "C++: ...". Instead of putting the string You explained the change in the first comment of this pull request. |
|
I forgot to write the most important message; thank you. I'm not sure whether I can ask this or not but... |
|
thanks for the feedback, I'll incorporate it tomorrow. I expected to squash the entire PR into a single commit after all, but I'll rewrite the history as requested! |
delsner
force-pushed
the
bugfix/#3388-fix-template-function-return-type
branch
from
aaf6ca2
to
586eaee
Compare
|
@masatake feel free to check again. Regarding making the comments more consistent: I added an explanation on why parsing non-nested greater than signs is not necessary (syntax error) and left a note pointing to the issue where the deleted code used to be. |
|
(The failure on Cygwin is nothing to do with this pull request.) |
|
I'm trying to fix the failures on Cygwin. |
|
Could you rebase your change on the LATEST main branch? |
delsner
force-pushed
the
bugfix/#3388-fix-template-function-return-type
branch
from
586eaee
to
c8de22f
Compare
done, let's see! |
|
I read the changes. Thank you. It looks good to me. I will merge this pull request. |
…pp compilers Close universal-ctags#3388. Removes C++ template parsing code that was originally written to support C++03-specific template syntax. However, as described in universal-ctags#3388, this syntax is not actually valid C++03 syntax. Yet, the parsing code removed in this commit prevents correctly parsing non-primitive template function return types.
delsner
force-pushed
the
bugfix/#3388-fix-template-function-return-type
branch
from
c8de22f
to
7dd0cdf
Compare
|
Thank you very much. |
Fixes issue #3388, where the C++ parser does not correctly parse template function return types and therefore misses functions.
This PR removes C++ template parsing code that was originally written to support C++03-specific template syntax. However, as described in #3388 this syntax is not actually valid C++03. Yet, this code prevents correctly parsing non-primitive template function return types.