main: Don't strdup the inputFileName when storing a tag to the corkQueue #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3682 +/- ##
==========================================
- Coverage 82.88% 82.88% -0.01%
==========================================
Files 224 224
Lines 54684 54689 +5
==========================================
+ Hits 45327 45330 +3
- Misses 9357 9359 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
When storing a tag entry to the corkQueue, the most of members of the tag entry are duplicated for isolating the the stored tag entry from the original parsing context. In the most of all cases, we can expect all tag entries in the corkQueue has the same value as inputFileName member. Strdup'ing the value is waste of memory resource especially when the input file name is long. Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--reuse-input-file-name-in-corkqueue
branch
from
d18bbb3
to
9fd7417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storing a tag entry to the corkQueue, the most of members of the tag entry are duplicated for isolating the the stored tag entry from the original parsing context.
In the most of all cases, we can expect all tag entries in the corkQueue has the same value as inputFileName member. Strdup'ing the value is waste of memory resource especially when the input file name is long.