Misc fix #3713
Merged
Misc fix #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
…table-extend option Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
… to a signature string The original code scanned corkQueue to pick up tags for making signature string. To avoid adding unwanted tags to the signature string, isTagExtra was used (522de3f). However, filtering with isTagExtra was too aggressive; tags extracted by the CPreProcessor parser running as a part of guest parser were rejected. This change uses an intArray. Instead of filtering candidate items in the corkQueue, the CPreProcessor collects tags for parameters to the intArray. The parameters are parts of a signature, not candidates. Therefore we don't need "filtering" anymore. Signed-off-by: Masatake YAMATO <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
+ Coverage 82.96% 82.99% +0.03%
==========================================
Files 226 226
Lines 54962 54972 +10
==========================================
+ Hits 45598 45626 +28
+ Misses 9364 9346 -18
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.