Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: use Visual Studio 2019 image #3815

Conversation

leleliu008
Copy link
Member

No description provided.

@leleliu008 leleliu008 force-pushed the update-appveyor-image-and-msvc-version branch 2 times, most recently from d7ee1e5 to 6115bb6 Compare September 15, 2023 02:03
@leleliu008
Copy link
Member Author

It's very intresting.

GitHub Actions use Visual Studio 2019 Enterprise has no warnnings.
AppVeyor use Visual Studio 2019 Community repots some warnnings. due to /WX option is used, these warrnings are treated as errors and abort the build process.

@leleliu008
Copy link
Member Author

C:\projects\ctags\peg\peg_common.h(133): error C2220: the following warning is treated as an error
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%2lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%4lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
kotlin.c
C:\projects\ctags\peg\peg_common.h(133): error C2220: the following warning is treated as an error
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%2lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%4lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
thrift.c
C:\projects\ctags\peg\peg_common.h(133): error C2220: the following warning is treated as an error
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%2lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%4lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
elm.c
C:\projects\ctags\peg\peg_common.h(133): error C2220: the following warning is treated as an error
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%2lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
C:\projects\ctags\peg\peg_common.h(133): warning C4477: 'fprintf' : format string '%4lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
C:\projects\ctags\peg\peg_common.h(133): note: consider using '%zu' in the format string
Generating Code...
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.EXE"' : return code '0x2'

the MSVC compiler tell us using '%zu' instead of '%lu'

@leleliu008 leleliu008 force-pushed the update-appveyor-image-and-msvc-version branch from 6115bb6 to 84bd546 Compare September 16, 2023 03:04
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (481ad1b) 85.03% compared to head (84bd546) 85.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3815   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files         227      227           
  Lines       53889    53889           
=======================================
  Hits        45824    45824           
  Misses       8065     8065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake
Copy link
Member

I will merge this pull request because #3795 requires it.
@k-takata, your review, and comments are welcome even after merging.

@masatake masatake merged commit dedfed1 into universal-ctags:master Sep 19, 2023
41 checks passed
@masatake
Copy link
Member

@leleliu008 Can I ask you to update docs/windows.rst?
Just doing s/2013/2019/ is enough?

@k-takata
Copy link
Member

LGTM.

@masatake
Copy link
Member

@k-takata, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants