Update kotlin parser #3841
Merged
Update kotlin parser #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3841 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 228 228
Lines 53982 53982
=======================================
Hits 45914 45914
Misses 8068 8068 ☔ View full report in Codecov by Sentry. |
|
@dolik-rce Thank you. Don't we need a test case for the change? |
|
@masatake: I don't think so. The changes are really minor and the existing tests only check basic kotlin syntax. It might be good idea to try to compose a kotlin file that would cover all the rules, but it would be quite big and tedious to construct, so it wouldn't fit into this PR. |
|
@dolik-rce I see. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a few small improvements to the Kotlin language specification this year, so it's time to update the grammar for the kotlin parser.