-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(man): write about guest parsers #3892
docs(man): write about guest parsers #3892
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3892 +/- ##
=======================================
Coverage 85.29% 85.29%
=======================================
Files 232 232
Lines 55786 55786
=======================================
Hits 47582 47582
Misses 8204 8204 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very clearly written in general.
I commented on the questions I had when I read it.
A typo should be fixed.
Others are comments.
docs/man/ctags-client-tools.7.rst
Outdated
If the client tool knows what is ``c`` in JavaScript and what is ``c`` in CSS, | ||
the ``language:`` field provides enough information. If not, enabling ``K`` field with | ||
``--fields=+K`` may be helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not consistent with the description later. How about the followings?
The client tool can know what is
c
in JavaScript and what isc
in CSS by using pseudo-tags described later.
Enabling
K
field with--fields=+K
does not require the pseudo-tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Surprisingly (and sadly), many client tools hardcode single-letter kinds and long-name kinds. Such a tool can say what is c
in JavaScript input. The tool also knows the language for *.js
file. I'll revise the sentences you pointed out.
b8f4aaa
to
11e09f0
Compare
Close universal-ctags#3888 Close universal-ctags#3007 Signed-off-by: Masatake YAMATO <[email protected]>
11e09f0
to
aa39241
Compare
I could read very smoothly. |
@hirooih Thank you. |
Close #3888
Close #3007