Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for InfluxDB in HTTPS mode #580

Merged
merged 1 commit into from
May 1, 2022
Merged

Adding support for InfluxDB in HTTPS mode #580

merged 1 commit into from
May 1, 2022

Conversation

PharmaJap
Copy link
Contributor

@PharmaJap PharmaJap commented Apr 14, 2022

For security purposes, it is inadvisable to run InfluxDB on the public-facing internet in HTTP mode (for example, on a VPS).

This commit adds a checkbox to the InfluxDB service to enable HTTPS, for use with servers that are configured for it.

Compiled and running/sending successfully in both HTTP and HTTPS mode on a Lolin Wemos D1 Mini v4.

Copy link
Contributor

@pppedrillo pppedrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, there is a better way to keep code clean and get rid of dreaded copy-paste spaghetti.

pio/src/iSpindel.cpp Outdated Show resolved Hide resolved
pio/lib/Sender/Sender.cpp Outdated Show resolved Hide resolved
pio/lib/Sender/Sender.h Outdated Show resolved Hide resolved
Copy link
Contributor

@pppedrillo pppedrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But still I'd get rid of code duplication and use existing secure client instance.

@PharmaJap
Copy link
Contributor Author

Updated with an obvious solution that I missed; no spaghetti. Might be ready to ship?

@pppedrillo
Copy link
Contributor

@PharmaJap Lets tag @universam1

Copy link
Owner

@universam1 universam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks clean and good to maintain

@universam1 universam1 merged commit f176848 into universam1:master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants