Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning when dropping unsafe keys #57

Merged
merged 2 commits into from
Jun 12, 2023
Merged

feat: show warning when dropping unsafe keys #57

merged 2 commits into from
Jun 12, 2023

Conversation

nozomuikuta
Copy link
Member

Resolves #25

I hope I'm understanding intention of the conversation exactly. 🙌

@nozomuikuta nozomuikuta self-assigned this Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #57 (9aac5e5) into main (1a45bc4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           55        55           
  Branches        21        21           
=========================================
  Hits            55        55           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title chore: add warning for key dropping feat: add warning for key dropping Feb 24, 2023
@pi0 pi0 changed the title feat: add warning for key dropping feat: show warning when dropping unsafe keys Jun 12, 2023
@pi0 pi0 merged commit 6448fa6 into main Jun 12, 2023
@pi0
Copy link
Member

pi0 commented Jun 12, 2023

Thanks!

@pi0 pi0 deleted the chore/add-warning branch June 12, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when dropping keys for saftey in dev mode
2 participants