Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support safeDestr #70

Merged
merged 3 commits into from
Jun 12, 2023
Merged

feat: support safeDestr #70

merged 3 commits into from
Jun 12, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 12, 2023

strict option originally added in #11 by @tobiasdiez

This PR adds a new dedicated safeDestr utility leveraging named export support in destr v2 for more standard usage with strict mode being enabled.

This PR also enables strict mode for possible prototype pollution to fail instead of silent ignore. (slight behavior change for v2)

@pi0 pi0 requested a review from danielroe June 12, 2023 12:00
@pi0 pi0 changed the title feat: support destrSafe feat: support safeDestr Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #70 (a29e137) into main (50a8b95) will decrease coverage by 2.18%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   98.76%   96.59%   -2.18%     
==========================================
  Files           1        1              
  Lines          81       88       +7     
  Branches       32       34       +2     
==========================================
+ Hits           80       85       +5     
- Misses          1        3       +2     
Impacted Files Coverage Δ
src/index.ts 96.59% <75.00%> (-2.18%) ⬇️

@pi0 pi0 merged commit 1cb7b78 into main Jun 12, 2023
@pi0 pi0 deleted the feat/safe-destr branch June 12, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants