Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parseGitURI): support @ symbol in ref segment #153

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

matthewvolk
Copy link
Contributor

πŸ”— Linked issue

#152

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds support for @ characters in parseGitURI's inputRegex.

Since the @ character is not included in the <ref> character set [\w./-], tags containing @ won't be matched by this pattern, and will fallback to main. See linked issue for more detail.

Resolves #152

πŸ“ Checklist

  • I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly. N/A,

@matthewvolk
Copy link
Contributor Author

Hi @pi0 πŸ™‚

Wondering if I could bug you for a quick review on this one. As an additional note, when you approve the workflow runs, they might fail due to node-fetch-native being 1.6.2 β€”Β I noticed that downgrading to 1.6.1 fixes the errors. Let me know if you'd like a separate PR for that πŸ™

Thanks in advance!

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 changed the title fix: support at symbol in parseGitURI input regex fix(parseGitURI): support @ symbol in ref segment Mar 21, 2024
@pi0 pi0 merged commit 8128e33 into unjs:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseGitURI is not working for tags containing @ characters
2 participants