-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(https): support using encrypted private key and pkcs12 (pfx) keystore #80
Conversation
Hi dear @Mastercuber thanks for this nice PR looks so promising! It might take little bit longer until i can make a proper review on your PR and merge it. In the meantime, do you think you can refactor out https options normalization logic outof |
Hi @pi0 π I will extract the normalization into |
This was no big deal, so I refactored it now. One notice while reviewing this PR: Something other I noticed is, that |
Sorry for force pushing.. I got diverged branches. Would the right solution have been to discard my commits through the github web interface - like suggested - and sync the fork with the upstream (both through web interface), then rebase the upstream's main branch locally and then just push? I went an hard reset way now, involving patch files.. |
No worries. I have rebased it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks π―
β Type of change
π Description
This PR introduces 2 new options when starting a HTTPS server:
The test certificate has been removed and a
generate-cert.ts
script is now generating the cert and a keystore before executing the test. In this context the already existing setup script was made global (see vitest config) to only get executed once.Also a bunch of tests was introduced and the
types.ts
andcert.ts
files got a bit refactored.So now it's possible to pass the following combinations as https options:
π Checklist