fix(firebase): validate custom serverFunctionName (#2773)

unjs · Oct 8, 2024 · 1bf47ae · 1bf47ae
1 parent 92519e0
commit 1bf47ae
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/docs/2.deploy/20.providers/firebase.md b/docs/2.deploy/20.providers/firebase.md
@@ -263,3 +263,7 @@ export default defineNuxtConfig({
 ```
 
 ::
+
+::important
+`firebase.serverFunctionName` must be a valid JS variable name and cannot include dashes (`-`).
+::
diff --git a/src/presets/firebase/preset.ts b/src/presets/firebase/preset.ts
@@ -1,6 +1,7 @@
 import { defineNitroPreset } from "nitropack/kit";
 import { basename } from "pathe";
 import type { Plugin } from "rollup";
+import { genSafeVariableName } from "knitwork";
 import { updatePackageJSON, writeFirebaseConfig } from "./utils";
 
 export type { FirebaseOptions as PresetOptions } from "./types";
@@ -33,6 +34,16 @@ const firebase = defineNitroPreset(
         nitro.options.appConfig.nitro = nitro.options.appConfig.nitro || {};
         nitro.options.appConfig.nitro.firebase = nitro.options.firebase;
 
+        const { serverFunctionName } = nitro.options.firebase;
+        if (
+          serverFunctionName &&
+          serverFunctionName !== genSafeVariableName(serverFunctionName)
+        ) {
+          throw new Error(
+            `\`firebase.serverFunctionName\` must be a valid JS variable name: \`${serverFunctionName}\``
+          );
+        }
+
         // Replace __firebaseServerFunctionName__ to actual name in entries
         (rollupConfig.plugins as Plugin[]).unshift({
           name: "nitro:firebase",
@@ -41,7 +52,7 @@ const firebase = defineNitroPreset(
               return {
                 code: code.replace(
                   /__firebaseServerFunctionName__/g,
-                  nitro.options.firebase?.serverFunctionName || "server"
+                  serverFunctionName || "server"
                 ),
                 map: null,
               };