Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace global. in fewer instances #155

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix: replace global. in fewer instances #155

merged 1 commit into from
Apr 27, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

previous PR: nuxt/framework#3107

nuxt/nuxt#13796

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The following code was being replaced:

  const addRouteMiddleware = (name, middleware, options = {}) => {
    const nuxtApp = useNuxtApp();
    if (options.global || typeof name === "function") {
-     nuxtApp._middleware.global.push(typeof name === "function" ? name : middleware);
+     nuxtApp._middleware.globalThis.push(typeof name === "function" ? name : middleware);
    } else {
      nuxtApp._middleware.named[name] = middleware;
    }
  };

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 27, 2022
@danielroe danielroe requested a review from pi0 April 27, 2022 10:21
@danielroe danielroe self-assigned this Apr 27, 2022
@pi0 pi0 merged commit 73db5c9 into main Apr 27, 2022
@pi0 pi0 deleted the fix/global-replacement branch April 27, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants