fix(storage): validate and skip invalid mounts #1805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
fix #1804
β Type of change
π Description
This change checks whether or not the driver was provided to the storage mount point, as
opts.driver
in thecreateStorage
method is reading the driver. As a result, in previous versions, if no driver was provided, the build errors (which I have tested thoroughly) as it's trying to import a non-existing package with no proper error handling (non-existing due to the driver being "undefined"). This fixes that issue by not trying to import the driver if it wasn't specified, and in stead warning the user that the storage was not mounted, therefore allowing the build process to continue and succeed. In addition, this improves the DX as this error message provides more info than the previous default "Cannot find package 'undefined'", which may be confusing for new developers.π Checklist