Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(error): add cache-control: no-cache for 404 responses #2793

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix(error): add cache-control: no-cache for 404 responses #2793

merged 2 commits into from
Oct 15, 2024

Conversation

hywax
Copy link
Contributor

@hywax hywax commented Oct 13, 2024

🔗 Linked issue

#2447

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added a header for 404 errors

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hywax hywax requested a review from pi0 as a code owner October 13, 2024 18:53
@pi0 pi0 changed the title feat: add cache-control: no-cache header for 404 responses fix(error): add cache-control: no-cache for 404 responses Oct 15, 2024
pi0
pi0 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 13018e2 into unjs:v2 Oct 15, 2024
4 checks passed
@milanbauwens
Copy link

Hi, When routeRules are defined (in nuxt.config.ts, it seems like they take precedence over this fix.

Could you investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hywax @milanbauwens @pi0